fix: replace invalid dash/hyphen on env key #2036
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRURoot
approved these changes
May 6, 2025
dscho
reviewed
Aug 17, 2025
| export function getInput(name: string, options?: InputOptions): string { | ||
| const val: string = | ||
| process.env[`INPUT_${name.replace(/ /g, '_').toUpperCase()}`] || '' | ||
| process.env[`INPUT_${name.replace(/[- ]/g, '_').toUpperCase()}`] || '' |
There was a problem hiding this comment.
This would break many test setups that define, say, process.env.["INPUT_WHO-TO-GREET"]. You need some code to maintain backwards-compatibility, i.e.
process.env[`INPUT_${name.replace(/[- ]/g, '_').toUpperCase()}`] ||
process.env[`INPUT_${name.replace(/ /g, '_').toUpperCase()}`] || ''Having said that, I have yet to see any actions/ PR getting accepted when the PR author doesn't happen to work at GitHub. I don't understand the policy (at least I assume that there is an internal, not publicly communicated, policy not to accept "outside PRs"...) but that's what I have observed in the past. Not trying to spoil the party here, but wanting to dampen both your and my hopes to reflect realistic expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is for #2034